fix(Share): Add missing optional parameter to IManager::shareApiAllowLinks()#60809
Open
provokateurin wants to merge 1 commit into
Open
fix(Share): Add missing optional parameter to IManager::shareApiAllowLinks()#60809provokateurin wants to merge 1 commit into
provokateurin wants to merge 1 commit into
Conversation
…Links() Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parameter was added to the interface and the implementation in 6bccaf7. For some strange reason it was removed from the interface signature in 3183ea7, but not from the docs or the implementation. I suspect it might have been a rebase mistake.